Skip to content

fix(autocomplete): improve multiple mode accessibility #19571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manichandra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(autocomplete): improve multiple mode accessibility #19571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions packages/primeng/src/autocomplete/autocomplete.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,55 @@ describe('AutoComplete', () => {
}
});

it('should provide an accessible name for the multiple listbox', async () => {
testComponent.multiple = true;
testComponent.ariaLabel = undefined as any;
testComponent.ariaLabelledBy = undefined as any;
testComponent.placeholder = 'Select tags';
testFixture.changeDetectorRef.markForCheck();
await testFixture.whenStable();

const listElement = testFixture.debugElement.query(By.css('ul[role="listbox"]'));

expect(listElement.nativeElement.getAttribute('aria-label')).toBe('Select tags');
expect(listElement.nativeElement.getAttribute('aria-labelledby')).toBeNull();
});

it('should support labelledby for the multiple listbox', async () => {
testComponent.multiple = true;
testComponent.ariaLabelledBy = 'autocomplete-label';
testFixture.changeDetectorRef.markForCheck();
await testFixture.whenStable();

const listElement = testFixture.debugElement.query(By.css('ul[role="listbox"]'));

expect(listElement.nativeElement.getAttribute('aria-labelledby')).toBe('autocomplete-label');
});

it('should provide a default accessible name for the multiple listbox', async () => {
testComponent.multiple = true;
testComponent.ariaLabel = undefined as any;
testComponent.ariaLabelledBy = undefined as any;
testComponent.placeholder = undefined as any;
testFixture.changeDetectorRef.markForCheck();
await testFixture.whenStable();

const listElement = testFixture.debugElement.query(By.css('ul[role="listbox"]'));

expect(listElement.nativeElement.getAttribute('aria-label')).toBe('Option List');
});

it('should not render the multiple input wrapper as an option', async () => {
testComponent.multiple = true;
testFixture.changeDetectorRef.markForCheck();
await testFixture.whenStable();

const inputElement = testFixture.debugElement.query(By.css('input[role="combobox"]'));
const inputWrapper = inputElement.nativeElement.closest('li');

expect(inputWrapper.getAttribute('role')).toBe('presentation');
});

it('should support keyboard navigation', () => {
const inputElement = testFixture.debugElement.query(By.css('input'));

Expand Down
4 changes: 3 additions & 1 deletion packages/primeng/src/autocomplete/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ export const AUTOCOMPLETE_VALUE_ACCESSOR: any = {
[attr.data-p]="inputMultipleDataP"
[tabindex]="-1"
role="listbox"
[attr.aria-label]="ariaLabelledBy ? undefined : ariaLabel || placeholder || listLabel"
[attr.aria-labelledby]="ariaLabelledBy"
[attr.aria-orientation]="'horizontal'"
[attr.aria-activedescendant]="focused ? focusedMultipleOptionId : undefined"
(focus)="onMultipleContainerFocus($event)"
Expand Down Expand Up @@ -171,7 +173,7 @@ export const AUTOCOMPLETE_VALUE_ACCESSOR: any = {
</ng-template>
</p-chip>
</li>
<li [pBind]="ptm('inputChip')" [class]="cx('inputChip')" role="option">
<li [pBind]="ptm('inputChip')" [class]="cx('inputChip')" role="presentation">
<input
#focusInput
#multiIn
Expand Down
Loading