fix(breadcrumb): add nav landmark label inputs - #19569
Open
manichandra wants to merge 1 commit into
Open
Conversation
manichandra
force-pushed
the
fix/19527-breadcrumb-nav-aria-label
branch
2 times, most recently
from
May 10, 2026 15:59
b32e036 to
f47edf1
Compare
Breadcrumb root nav elements could not be labelled, causing axe-core landmark-unique violations when multiple Breadcrumb components are used on the same page. Added ariaLabel and ariaLabelledBy inputs to bind accessible labels to the root nav landmark, matching existing PrimeNG accessibility patterns used by other navigation components. Fixes primefaces#19527
manichandra
force-pushed
the
fix/19527-breadcrumb-nav-aria-label
branch
from
May 10, 2026 15:59
f47edf1 to
6dcce29
Compare
manichandra
changed the title
Contributor
Author
|
@mehmetcetin01140 can you please review and get this merged. let me know if I need to anything to pass the failing CI checks ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breadcrumb root nav elements could not be labelled, causing axe-core landmark-unique violations when multiple Breadcrumb components are used on the same page. Added ariaLabel and ariaLabelledBy inputs to bind accessible labels to the root nav landmark, matching existing PrimeNG accessibility patterns used by other navigation components.
Fixes #19527
Verification:
ng test primeng --watch=false --browsers=ChromeHeadless --include='**/breadcrumb.spec.ts'
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.