Skip to content

fix: A2A top-level failures return failed Task with AdCP envelope, not JSON-RPC InternalError - #1547

Draft
numarasSigmaSoftware wants to merge 154 commits into
prebid:mainfrom
numarasSigmaSoftware:pr/a2a-error-routing
Draft

fix: A2A top-level failures return failed Task with AdCP envelope, not JSON-RPC InternalError#1547
numarasSigmaSoftware wants to merge 154 commits into
prebid:mainfrom
numarasSigmaSoftware:pr/a2a-error-routing

fix: stop threading the outer task id into sync_creatives [order R4-1]

e36919d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Aug 17, 2026 in 8s

25 new alerts including 25 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 25 medium

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 51 in src/adapters/gam/managers/inventory.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 62 in src/adapters/gam/managers/sync.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 65 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 68 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 143 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 146 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 169 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 174 in src/adapters/gam/managers/targeting.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 771 in src/core/creative_agent_registry.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 115 in src/core/helpers/adapter_helpers.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 189 in src/core/helpers/adapter_helpers.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 165 in src/core/signals_agent_registry.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 247 in src/core/signals_agent_registry.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 488 in src/core/tools/creative_formats.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 180 in src/core/tools/products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 230 in src/core/tools/products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 238 in src/core/tools/products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 272 in src/core/tools/products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 359 in src/core/tools/products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 112 in src/core/workflow_finalization.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.

Check warning on line 57 in src/services/dynamic_pricing_service.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 52 in src/services/dynamic_products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 61 in src/services/dynamic_products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 105 in src/services/dynamic_products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.

Check warning on line 157 in src/services/dynamic_products.py

See this annotation in the file changed.

Code scanning / CodeQL

Log Injection Medium

This log entry depends on a
user-provided value
.