Fix #1297: configurable rewarded completion timeout - #1306
Closed
mdanylov-sigma wants to merge 2 commits into
Closed
Fix #1297: configurable rewarded completion timeout#1306mdanylov-sigma wants to merge 2 commits into
mdanylov-sigma wants to merge 2 commits into
Conversation
OlenaPostindustria
requested changes
Aug 6, 2026
Collaborator
|
Also, worth adding the new property to public docs |
YuriyVelichkoPI
requested changes
Aug 8, 2026
YuriyVelichkoPI
left a comment
Contributor
There was a problem hiding this comment.
Blocked since there is a way to implement the requested functionality without changes in the SDK:
#1297 (comment)
Collaborator
Author
|
The supported rwdd passthrough and setImpORTBConfig approach is now documented in prebid/prebid.github.io#6697. I have left this SDK PR open because the latest review rejects the SDK API itself, so closing or withdrawing it requires an explicit decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the previously hard-coded 120s
RewardedConfig.defaultCompletionTimepublisher-configurable via a newrewardedCompletionTimeoutproperty onVideoControlsConfiguration(default120, matching prior behavior), with pass-throughs onRewardedAdUnit,MediationBaseInterstitialAdUnit, and a new direct property onInterstitialController.Closes #1297
Behavior
DisplayView.loadAd()andInterstitialController.loadAd()intoRewardedConfig.defaultCompletionTimebefore the transaction factory is created.PBMHTMLCreative.setupRewardTimerIfNeeded) when the bid omitsendcardTime/bannerTime— it does not affect the primary VAST video reward-completion path (playback-event/percentage based), which is unrelated and untouched.Testing
PrebidMobileTests(unit): 22/22 passed, including new tests:testRewardedCompletionTimeout(default/override/negative-rejection)testInterstitialControllerPropagatesRewardedCompletionTimeout— exercisesInterstitialController.loadAd()end-to-end and assertsrewardedConfig.defaultCompletionTimereflects the configured value.testDisplayViewPropagatesRewardedCompletionTimeout— same forDisplayView.loadAd().testRewardEvent_EndcardUsesConfiguredFallbackAPI / compatibility
RewardedConfig.defaultCompletionTimechangeslet→var: additive, non-breaking for Objective-C consumers.TimeIntervalproperties are plain@objcMembers-compatible, consistent with existing config surface.