Fix #1296: configurable video interstitial auto-close - #1305
Fix #1296: configurable video interstitial auto-close#1305mdanylov-sigma wants to merge 3 commits into
Conversation
|
When |
OlenaPostindustria
left a comment
There was a problem hiding this comment.
LGTM, left a suggestion
|
It would also be good to document the new property in the public documentation |
YuriyVelichkoPI
left a comment
There was a problem hiding this comment.
Please support new property in ORTBAdConfiguration and update the spec for Ad Experience Controls respectively
https://docs.prebid.org/prebid-mobile/modules/rendering/combined-ad-experience-controls.html
|
Addressed in 097c52d: the value now parses through ORTBAdConfiguration, rewarded ads defer to rwdd.close.action, and the public documentation update is in prebid/prebid.github.io#6697. |
Summary
Adds a publisher-configurable
isAutoCloseOnCompletionEnabledflag (defaulttrue, preserving existing behavior) onVideoControlsConfiguration, exposed onInterstitialRenderingAdUnit,RewardedAdUnit, andMediationBaseInterstitialAdUnit. When disabled, a full-screen video interstitial without a companion/end card no longer auto-dismisses when playback completes — the publisher (or the rewarded close-action flow) controls when it closes.Closes #1296
Behavior
true): unchanged from current behavior — video without a companion still auto-closes on completion.false:[modalManager creativeDisplayCompleted:]is still called unconditionally (so rewarded completion is still reported toModalManagerand rewarded close-action handling —closeButton/autoClose/unknown— still runs correctly), but the automaticdismissInterstitialModalState()call is skipped.closeDelaycountdown inModalViewController, independent of this flag, so they can never get stuck.Testing
PrebidMobileTests(unit): 25/25 passed, including new tests:testInterstitialWithoutCompanionAutoClosesByDefaulttestInterstitialWithoutCompanionCanDisableAutoClosetestRewardedCompletionIsReportedWhenAutoCloseIsDisabled— explicitly verifiesModalManager.creativeDisplayCompleted(_:)still fires for a rewarded ad when auto-close is disabled.testAutoCloseOnCompletion(config default/override)PrebidDemoSwiftUITests(real UI test, live ad serving):testInAppVideoInterstitialAdpassed.API / compatibility
@objcMembersproperty, consistent with the existingisSoundButtonVisiblepattern across all three ad unit surfaces — no Objective-C interop concerns, no breaking changes, default preserves current behavior for existing integrations.