Reklamup Bid Adapter: update adapter

[prebid-reklamup]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

Documentation PR: prebid/prebid.github.io#6666

[barecheck]

Barecheck - Code coverage report

Total: 96.66%

Your code coverage diff: 0.00% ▴

Uncovered files and lines

File	Lines
test/spec/modules/reklamupBidAdapter_spec.js	238-241, 243-244

[prebid-reklamup]

Hi, @robertrmartinez! Can you please check is everything is ok with PR.

[github-actions]

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

[robertrmartinez]

@prebid-reklamup please add a unit test for this also!

I know it is only a two line diff but we do ask for coverage on changed code, and there are like 20+ adapters that already assert this so it is a one liner:

it('should have the correct gvlid', function () {
    expect(spec.gvlid).to.equal(1619);
});

that way if someone ever fat fingers the ID or drops the property in a refactor we catch it.

[prebid-reklamup]

@prebid-reklamup please add a unit test for this also!

I know it is only a two line diff but we do ask for coverage on changed code, and there are like 20+ adapters that already assert this so it is a one liner:

it('should have the correct gvlid', function () {
    expect(spec.gvlid).to.equal(1619);
});

that way if someone ever fat fingers the ID or drops the property in a refactor we catch it.

Done, new test added.