Fix early strain reduction in Reading allowing for the addition of notes to decrease PP - #38530
Open
piiidosu wants to merge 8 commits into
Open
Fix early strain reduction in Reading allowing for the addition of notes to decrease PP#38530piiidosu wants to merge 8 commits into
piiidosu wants to merge 8 commits into
Conversation
tsunyoku
requested changes
Aug 5, 2026
tsunyoku
reviewed
Aug 5, 2026
tsunyoku
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38268 by removing dependance on removed objectList and fixing issues with rebase.
This PR fixes a bug in early difficulty reduction for the reading skill, where adding more objects in the first 60 seconds of a map can decrease difficulty.
The Bug:
reducedNoteCount is equal to the number of objects in the first 60s. As index/reducedNoteCount was used to determine the ratio for the nerf, increasing the objects in the first 60s increases reducedNoteCount, and decreases the ratio, which increases the nerf to the object, leading to cases where adding more objects decreases difficulty.
The Fix:
Use StartTime instead of index so that an object at a given start time will receive the same nerf regardless of the number of objects preceding or following the object.
Notes:
This significantly nerfs short maps (shorter than 40s, see below), as the original nerf would rescale the nerf window to the length of the map if the map was shorter than 60s.
The reduction period was changed from 60s to 40s to compensate.
The baseline reduction penalty was changed from 0 to 0.2