Add adjustable rhythm-based colouring to osu!mania - #38495
Open
prplnorangesoda wants to merge 4 commits into
Open
Add adjustable rhythm-based colouring to osu!mania#38495prplnorangesoda wants to merge 4 commits into
prplnorangesoda wants to merge 4 commits into
Conversation
Author
|
sorry about the inspectcode spam, my local script isn't working for some reason 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #38481. i did not use AI so if the code looks shit it's my fault
adds new items to the [Colours] section of
skin.ini,SnapDefaultandSnap{divisor}that affect how notes are coloured when the Timing-based note colouring option is enabled. ifSnapDefaultis specified, unspecified snap colours fall back to that colour, otherwise falls back to default snap colourssyntax:
notably, allows support for stepmania-style colouring:
currently does not work with the Synesthesia mod, pending feedback.
implementation details: reinherits the osu!mania skinning scene component to
ManiaSkinnableTestSceneScrollingas the snap colouring test uses the same base logic but does not scroll. adds just one new test scene that checks if the notes are coloured correctly. map editor code and Synesthesia mod code still points toBindableBeatDivisor.GetColourForbut renamed toGetDefaultColourForto be more accuratei'd like to know if there is a better way of implementing the snap colours in
SkinConfigurationas the default list code is pretty dodgy and isn't const because the code ported fromBindableBeatDivisoris reliant on anOsuColour.