RankedPlay / Quickplay queue NullReferenceException - #38490
Merged
Merged
Conversation
Contributor
Author
|
Went ahead and moved the testcase into |
…lReferenceException Move TestRoomScreenPushNullHandling to TestSceneMatchmakingQueueScreen
Member
|
@smoogipoo i'm going to get this in because it's an actual issue affecting users, but recommend you check on this when you get back. |
peppy
approved these changes
Aug 7, 2026
peppy
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #38482
The original error in the logs refers to a NullReferenceException in
UserActivity.cs::InLobby, but that is just the first place the null room is accessed when theScreenQueue.csmoves the user to theRankedPlayScreen.I initially assumed it was from the user getting disconnected and the room set to null during the BeginDelayedSequence(2000) in
ScreenQueue.cs, but I couldn't replicate that regardless of what I tried (and there is a similar test case inTestSceneMatchmakingQueueScreenwith a comment about this). What did end up recreating this was leaving the room first, then changing to an in room state after.I added a new visual test which replicates the issue, and added a room null check to
ScreenQueue.csto prevent it. When it occurs the matchmaking screen will return to an idle state. My main question would be: what indication should be shown to the user that the queue failed and reset?Any feedback is appreciated!