You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally the clock is reset on onGameplayStarted, then the intro is automatically skipped on RequestIntroSkip (from SkipOverlay.SkipWhenReady).
However, if at least one other player stays in PlayerLoader, the players who enter the loaded state first are able to click the skip overlay before the gameplay starts.
This causes the clock to skip the intro first, then reset back to zero as the gameplay starts.
Test passes on PR / fails on master, but currently has two problems.
The map used in TestBeatmap does not have a skippable intro, and the test will fail from trying to click a nonexistent skip overlay button. I have confirmed the test works by changing the beatmap string locally, but that isn't included in the PR. In the event changing the beatmap is allowed, I think this map with a 6 second intro may be a good alternative.
ServerAPIRoom, the Room used for initializing MultiplayerPlayer in the test scene, doesn't update after the room is created. I was not able to enable auto skip from just calling ChangeSettings().
The two methods that made it possible was to either create a Room with AutoSkip enabled for JoinRoom(), or use ClientAPIRoom (which does get updated from changing settings) when initializing gameplay instead. PR currently uses the latter but I'm not sure which one I should go with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36783 and #37906.
Ideally the clock is reset on
onGameplayStarted, then the intro is automatically skipped onRequestIntroSkip(fromSkipOverlay.SkipWhenReady).However, if at least one other player stays in
PlayerLoader, the players who enter the loaded state first are able to click the skip overlay before the gameplay starts.This causes the clock to skip the intro first, then reset back to zero as the gameplay starts.