Skip to content

fix: don't duplicate prefixed rule when selector list was reformatted #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ai merged 1 commit into from
Jul 16, 2026
+12 −1
Merged

fix: don't duplicate prefixed rule when selector list was reformatted #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ class Selector extends Prefixer {
return false
}

let beforeSelector = list.comma(before.selector).join(', ')

let some = false
for (let key in prefixeds[this.name]) {
let prefixed = prefixeds[this.name][key]
if (before.selector === prefixed) {
if (beforeSelector === prefixed) {
if (prefix === key) {
return true
} else {
Expand Down
9 changes: 9 additions & 0 deletions test/selector.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ test('finds prefixed even if unknown prefix is between', () => {
is(selector.already(css.nodes[2], prefixeds, '-moz-'), true)
})

test('finds prefixed even if selector list was reformatted', () => {
let css = parse(
'.a::-moz-selection,\n.b::-moz-selection {}\n' +
'.a::selection,\n.b::selection {}'
)
let prefixeds2 = selector.prefixeds(css.nodes[1])
is(selector.already(css.nodes[1], prefixeds2, '-moz-'), true)
})

test('adds prefix to selectors', () => {
equal(
selector.replace('body ::selection, input::selection, a', '-ms-'),
Expand Down