perf: reuse the natural sort collator - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋🏻
naturalSortcallslocaleComparewith options on every comparison, which repeats collator setup during sorting.This reuses a single
Intl.Collator, created on the first comparison so imports don't pay the initialization cost. It keeps the default locale and the same options:numeric: trueandsensitivity: 'base'.Tests cover ordering against the previous implementation and numeric path sorting through
fsReadAll.Build, lint, typecheck and all 182 tests pass on Node 26.5.1.