Fix wrong coords being read by check task during dim change on Folia - #119
Open
Warriorrrr wants to merge 1 commit into
Open
Fix wrong coords being read by check task during dim change on Folia#119Warriorrrr wants to merge 1 commit into
Warriorrrr wants to merge 1 commit into
Conversation
pop4959
approved these changes
Aug 30, 2026
pop4959
left a comment
pop4959
left a comment
Owner
There was a problem hiding this comment.
Looks fine to me. Change itself makes sense, it's definitely an improvement to schedule the check per player on their respective scheduler on Folia.
Github diff is a bit messy but I can see you basically just copied everything from the run method into check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the possibility of the border check task being able to see the player at coordinates which aren't correct while they're in the process of changing dimensions, due to the border check task running on the global region instead of as an entity task.
Depends on #118 to raise the chunky dependency version & subsequently the java version
It's easier to reproduce if the check interval is set to 1 tick & teleporting into ungenerated chunks, I entered a portal at around x & z 20k in the overworld but the task saw me at those same coordinates in the nether:
