Skip to content

feat: add option to toggle shake cursor to find it - #2100

Merged
mmstick merged 2 commits into
pop-os:masterfrom
hojjatabdollahi:hojjat/shake-to-locate
Aug 21, 2026
Merged

feat: add option to toggle shake cursor to find it#2100
mmstick merged 2 commits into
pop-os:masterfrom
hojjatabdollahi:hojjat/shake-to-locate

Conversation

@hojjatabdollahi

@hojjatabdollahi hojjatabdollahi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Depends on:

The string for the toggle is from KDE.
It's on by default.

image
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@maria-komarova

Copy link
Copy Markdown
Contributor

I wonder if "Shake mouse pointer to make it bigger" might be a more descriptive copy.

@KodeBarista

KodeBarista commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

In mac it's called "Shake mouse pointer to locate"

image

@hojjatabdollahi
hojjatabdollahi force-pushed the hojjat/shake-to-locate branch 2 times, most recently from 520eac4 to 082dba7 Compare August 17, 2026 03:28
@hojjatabdollahi

Copy link
Copy Markdown
Contributor Author

@maria-komarova How about adding a caption for it?

KDE has it as "shake cursor to find it" and MacOS has it has "shake cursor to locate it" so that precendent makes it more recongnizable by the users. But I also understand that your suggestion is more accurate. If you don't like to add the caption (since it's the only option with the caption) I can change the text to what you suggested.

image

@hojjatabdollahi
hojjatabdollahi marked this pull request as ready for review August 17, 2026 03:36
@leviport
leviport requested review from a team August 20, 2026 20:37
@leviport
leviport force-pushed the hojjat/shake-to-locate branch from 082dba7 to a16a814 Compare August 20, 2026 20:40
leviport
leviport previously approved these changes Aug 20, 2026

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new option appears and is working as expected. Since this only touches the accessibility page, I only did regression testing there, where I found no issues.

@hojjatabdollahi

Copy link
Copy Markdown
Contributor Author

@leviport
I still need to wait for the cosmic-comp part to merge first to update the cosmic-comp-config in cargo.toml. So, after force pushing that we need another review.

But if you can double check with @maria-komarova and make sure the final wording is OK, that would be great.

@leviport
leviport requested a review from a team August 20, 2026 21:43

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good after a quick re-test.

@mmstick
mmstick merged commit c7481ba into pop-os:master Aug 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants