feat: Grid workspace layout option with columns/rows settings - #2073
feat: Grid workspace layout option with columns/rows settings#2073AldenDana wants to merge 2 commits into
Conversation
|
AI disclosure This implementation was developed with assistance from Claude (Anthropic's AI coding assistant), directed and reviewed by me throughout — I specified the requirements, reviewed the generated diffs, and tested every feature live on my own machine. I'm continuing to work with Claude to address review feedback, so turnaround should be quick either way.
|
|
Is there a corresponding issue for this which has been approved by @pop-os/ux for implementation? Also, your commit descriptions are violating the AI policy. If any code within a commit was generated, it must be clearly documented in the commit descriptions. You will need to rebase this with proper citations. |
Adds a Grid choice to the Workspaces orientation section, with Grid columns / Grid rows spin buttons (shown while Grid is selected) writing workspace_grid_columns/workspace_grid_rows. The touchpad gestures description treats Grid like Vertical. Requires the cosmic-comp Grid layout change (WorkspaceLayout::Grid in cosmic-comp-config). Companion to pop-os/cosmic-workspaces-epoch#51. AI-assisted commit: implemented with Claude (Anthropic's AI coding assistant); the author directed the requirements, reviewed the generated diff, and tested the resulting behavior.
Lets you list, add, and remove per-app workspace assignment rules (cosmic-comp-config's workspace_assignments) directly from Settings, instead of hand-editing the config file. AI-assisted commit: implemented with Claude (Anthropic's AI coding assistant); the author directed the requirements, reviewed the generated diff, and tested the resulting behavior.
1c4f33d to
0e836fd
Compare
|
Fair on both counts. On the issue: no, there isn't a On the commits: rebased all four branches (this one, cosmic-comp#2555, cosmic-comp#2556, cosmic-workspaces-epoch#318) with an explicit AI-assisted disclosure appended to every commit message, and force-pushed. No code changes, message-only. |
|
@mmstick Could we have a discussion on pop-os/cosmic-workspaces-epoch#51 about adding this? It's literally the only feature preventing myself (and several others) from being able to move to COSMIC. Or - what's the process for discussing this? I'm happy to jump into a meeting or a chat on Mattermost. |
|
@funnylookinhat we decided to move workspaces into cosmic-comp for unrelated reasons but it also blocks additions at the moment. I think this feature would require a different mode for the current applet. Using the current workspace picker in the overview with a grid can consume the display leaving little space for spread windows - especially if there are a lot of them. I imagine an applet pop-up like from any other applet that shows the grid in a smaller preview above the window spread.
|
|
I think you've nailed the use cases! Looking forward to the rewrite into |
4 participants
Companion to pop-os/cosmic-comp#2555 (Grid workspace layout, pop-os/cosmic-workspaces-epoch#51).
Adds a Grid choice to Desktop → Workspaces → Workspaces orientation, with Grid columns / Grid rows spin buttons shown while Grid is selected, writing
workspace_grid_columns/workspace_grid_rows. The compositor hot-reloads the change live.The touchpad gestures description treats Grid like Vertical.
App workspace assignments. Also adds a new section to the Workspaces page for pop-os/cosmic-comp#2556's per-app workspace rules (
workspace_assignments): lists existing rules, lets you remove one, and lets you add a new one (app ID + target workspace number). Previously the only way to manage these was the window context menu or hand-editing the config file; this gives a bulk-management view alongside it.Depends on the
cosmic-comp-configchanges from pop-os/cosmic-comp#2555 and pop-os/cosmic-comp#2556; to build/test before those merge, add a[patch]forcosmic-comp-configpointing at those branches.