Caps lock bindings - #168
Open
krakotay wants to merge 9 commits into
Open
Conversation
Track keycodes in binding identity and remove the pinned Rust toolchain.
This was referenced Jul 15, 2026
rustfmt didn't want to format this section at all, so I split up match branches into functions and now it works.
The external brightness thread held Display handles (open /dev/i2c-* fds) for the daemon's lifetime, only re-enumerating on the next brightness change >10s after the previous one. An open fd on an i2c adapter belonging to an unplugged DP-MST monitor blocks the kernel's MST teardown (drm_dp_delayed_destroy_work waits in i2c_del_adapter), permanently wedging drm_dp_mst_wq: hung-task warnings, stalled hotplug handling, and stale connectors that break saved output configurations on replug. Keep the handle cache only while brightness changes are actively arriving: wait on the condvar with a 2s timeout while handles are held, and drop them once no change has arrived in that window. Bursts of brightness key repeats still reuse the cached handles; an idle daemon holds no i2c fds, so MST teardown can complete. Fixes pop-os#165
Track keycodes in binding identity and remove the pinned Rust toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of two other PRs
cosmic-comp PR
cosmic-settings PR
Together, they make it possible to bind modifier-only keyboard shortcuts, such as changing the input source with Alt+Shift, Ctrl+Shift, Super+Shift, or even Caps Lock.