Skip to content

refactor: nix flake for build and dev - #138

Open
karlskewes wants to merge 2 commits into
pop-os:masterfrom
karlskewes:nix-flake
Open

refactor: nix flake for build and dev#138
karlskewes wants to merge 2 commits into
pop-os:masterfrom
karlskewes:nix-flake

Conversation

@karlskewes

@karlskewes karlskewes commented Mar 20, 2026

Copy link
Copy Markdown

The existing flake didn't build for me.
Refactored per: pop-os/cosmic-comp#2219 (comment)

I used the refactored flake for nix build and nix develop of #137.

AI Disclosure

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Comment thread Cargo.lock Outdated
@mmstick

mmstick commented Jun 2, 2026

Copy link
Copy Markdown
Member

Are these still needed for NixOS packaging?

@karlskewes

Copy link
Copy Markdown
Author

Are these still needed for NixOS packaging?

Thanks for asking!

NixOS itself maintains its own packaging nix files like this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/co/cosmic-settings-daemon/package.nix

This PR and pop-os/cosmic-comp#2219 enable build and development of the Cosmic component in a nix "dev shell".
I used these to develop the linked pinned workspaces feature PR's.

Most of the Cosmic repo's have nix files already in various states of utility/working/broken.
So I figure the project could either abandon/remove them or I could go around and update them to be working and based on what NixOS do upstream which I figure is generally best practice.

Happy to mark ready/close/do the needful.

@karlskewes
karlskewes marked this pull request as ready for review August 28, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants