Skip to content

chore: update smithay - #2759

Merged
Drakulix merged 1 commit into
masterfrom
smithay_noble
Aug 26, 2026
Merged

chore: update smithay#2759
Drakulix merged 1 commit into
masterfrom
smithay_noble

Conversation

@Drakulix

Copy link
Copy Markdown
Member

This was a bit tricky, since the new pointer constraint handling is a little deadlock prone...

@pop-os/quality-assurance This needs testing for fullscreen games that capture the cursor (most FPS games) and other apps that confine the cursor (e.g. VMs).

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@Drakulix
Drakulix requested review from a team August 19, 2026 10:41
ids1024
ids1024 previously approved these changes Aug 21, 2026
@jklgrasso jklgrasso self-assigned this Aug 24, 2026
@jklgrasso

Copy link
Copy Markdown

This is definitely better regarding VirtualBox. That being said, I can move the mouse out of the VM window without unbinding it. This happens with the current release of cosmic-comp as well.

In full-screen games (tested with CS2 native and Helldivers 2 w/Proton), if I try to switch windows or workspaces, my system crashes. That does not happen with the current version of cosmic-comp. In CS2, the system crashes in a match (practice mode used for testing), but not in the main menu. I assume CS2 doesn't "fully" capture the mouse until it's in a match.

@skygrango

Copy link
Copy Markdown
Contributor

This might be helpful: Smithay/smithay#2144

@skygrango skygrango mentioned this pull request Aug 26, 2026
5 tasks
@Drakulix

Copy link
Copy Markdown
Member Author

Updated to include the InputTime update and deadlock fixes for PointerConstraints.

Cannot reproduce the freeze/crash anymore with Helldivers 2 @jklgrasso.

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Drakulix
Drakulix merged commit 5c93094 into master Aug 26, 2026
2 checks passed
@Drakulix
Drakulix deleted the smithay_noble branch August 26, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants