fix(kms): recover from DRM master handoff failure - #2636
Open
francocarballar wants to merge 1 commit into
Open
Conversation
Abort startup before readiness when the primary DRM device is not authenticated, allowing systemd to retry the session handoff with a fresh descriptor. Also fix existing Clippy warnings required by CI. AI-assisted: developed with assistance from OpenAI Codex. Signed-off-by: Franco Carballar <francocarballar@gmail.com>
Member
|
This is not the correct solution to this issue. Rather what needs to be fixed is the greeter keeping the drm master state. Which was already done (but not yet tagged) in #2382 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2635
Summary
Root cause
When the greeter still owns DRM master during startup, Smithay can initialize the device as unprivileged. cosmic-comp previously continued startup and announced readiness, leaving the graphical session on a black screen.
Validation
cargo +stable fmt --all -- --checkcargo +stable clippy --all-features -- -D warningscargo +stable check --all-targetscargo +stable check --no-default-featurescargo +stable check --features debugcargo +stable check --features profile-with-tracycargo +stable check --features profile-with-tracy-gpucargo +stable test --all-featuresgit diff --checkAll automated checks passed.
Hardware validation on the affected Dell Latitude 3520 has not been performed yet because reproducing the DRM handoff can make the graphical session unavailable.
Contributor declarations
git commit -s.