Skip to content

fix(a11y): Make mouse-wheel zoom also configurable with accessibility_zoom.increment - #2634

Open
luukvanderduim wants to merge 1 commit into
pop-os:masterfrom
luukvanderduim:configurable-zoom-step-size
Open

fix(a11y): Make mouse-wheel zoom also configurable with accessibility_zoom.increment#2634
luukvanderduim wants to merge 1 commit into
pop-os:masterfrom
luukvanderduim:configurable-zoom-step-size

Conversation

@luukvanderduim

Copy link
Copy Markdown
Contributor

Hooked mouse-scroll zoom up to the accessibility_zoom.increment configuration instead of using a fixed 5% step.

Magnification through keyboard Super + = / - already has the step size hooked up to the configurable accessibility_zoom.increment. This commit unifies the behaviour between mouse-wheen and keyboard controlled zoom.

This also makes one mouse wheel click approximately the same size as one keyboard step size. Closing the gap of perceived differences between both modes of operation.

LLM disclosure:
Gemini Flash 3.5 was helpful in finding where the problem was located and suggested the initial fix.
That said, each line introduced is simple, well tested and well understood.

Tested on: x86_64 Xubuntu 26.04 with Cosmic Epoch 1.4 and a patched cosmic-comp.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Hooked mouse-scroll zoom up to the configured `accessibility_zoom.increment` instead of using a hardcoded 5% step.

Magnification through keyboard `Super + = / -` already had the step size hooked up to the configurable
`accessibility_zoom.increment`. This commit unifies the behaviour among these modes.

This also makes one mouse wheel click approximately the same size as one keyboard step size.
Erasing apparent differences between both modes.

LLM disclosure:
Gemini Flash 3.5 was helpful in finding where the problem was located and suggested this fix.
That said, each line is simple, well tested and well understood

Tested on: x86_64 Xubuntu 26.04 with Cosmic Epoch 1.4
@luukvanderduim
luukvanderduim force-pushed the configurable-zoom-step-size branch from a6d9848 to c9751d3 Compare August 22, 2026 11:43
@rillbert

Copy link
Copy Markdown

Tested the rebased branch on Pop!_OS 24.04, ThinkPad with AMD integrated graphics driving an external monitor. Built with cargo build --profile fastdebug and ran it as my normal session.

Works well for me. At the default scroll speed with a 50% zoom increment I get a zoom doubling in about 3 detents, for the mousewheel which is comfortably usable. Before this I had to push the mouse scroll speed to ~65 to get fast enough zoom to be usable, which made scrolling in Firefox far too coarse. I haven't seen any regression in normal scrolling.

@luukvanderduim

Copy link
Copy Markdown
Contributor Author

Works well for me. At the default scroll speed with a 50% zoom increment I get a zoom doubling in about 3 detents, for the mousewheel which is comfortably usable. Before this I had to push the mouse scroll speed to ~65 to get fast enough zoom to be usable, which made scrolling in Firefox far too coarse. I haven't seen any regression in normal scrolling.

It took me a while before I understood you had found a workaround by increasing mouse scroll-speed, which had unwanted side-effects.

Glad to hear this works for you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants