Skip to content

Fix: Make cursor position more consistant - #2593

Open
Astatin3 wants to merge 7 commits into
pop-os:masterfrom
Astatin3:master
Open

Fix: Make cursor position more consistant#2593
Astatin3 wants to merge 7 commits into
pop-os:masterfrom
Astatin3:master

Conversation

@Astatin3

Copy link
Copy Markdown
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

What this does:

  • Cursor is now initialized in the center of the output when a seat is created (A small pet peeve of mine with Cosmic)
  • When a output is removed, and the cursor is inside of it, it is set to the center of the 0th index output (see the comment at src/shell/mod.rs:940)
  • Keeps track of the relative position of the cursor to the output when monitors are connected or removed, the cursor isn't teleported about the screen because the geometry changed

I was only able to test this on Wayland, with one external monitor, some more testing would definitely be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant