Implement division without resorting to inverse the multiplication - #28
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a MoneyQuotient expression node and visitor support intended to represent division directly (rather than as multiplication by an inverse), aiming to improve numerical exactness for sequences like * 0.6666 / 0.6666.
Changes:
- Added
MoneyQuotientexpression node and extended the visitor interfaces/implementations to handle it. - Added division support to
MoneyBagto enable evaluation of quotient expressions. - Added a new FsCheck test and updated the README requirements list.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a new TDD requirement entry describing quotient-based division motivation. |
| Funcky.Money/Visitors/ToHumanReadableVisitor.cs | Adds human-readable formatting for MoneyQuotient. |
| Funcky.Money/Visitors/MoneyBag.cs | Adds Divide(decimal ...) and DivideBag(...) to support quotient evaluation. |
| Funcky.Money/Visitors/IMoneyExpressionVisitor.cs | Extends the visitor interface with Visit(MoneyQuotient ...). |
| Funcky.Money/Visitors/EvaluationVisitor.cs | Adds evaluation support for MoneyQuotient via MoneyBag.Divide. |
| Funcky.Money/ExpressionNodes/MoneyQuotient.cs | Introduces the new MoneyQuotient expression node. |
| Funcky.Money.Test/DivisionImplementationTest.cs | Adds a new property-based test for multiply/divide round-tripping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.