feat(apps): iphone16-demo - #258
Conversation
…ncher display union Review fixes for pocket-stack#258: - apps/iphone16-demo/pocket.json landed without its row in the admission-matrix test, so the unit gate failed (expected[demo] undefined for every committed manifest is the test's contract). iphone16-demo resolves exactly like nsengine: vita-only through the shared touch + integer-fit contract, private ios-dev otherwise. - The committed launcher display registry (a cross-target union; each host intersects at runtime) regenerated via `bun tools/launcher.ts scan`, now carrying both vita-only demos, and the Vita-equality pin in tests/launcher-sim.test.ts evolves into subset + exact delta (["iphone16-demo-main", "nsengine-main"]). This overlaps the review commit on feat/ios-cli (f5a5975), which makes the same registry/test change for nsengine alone — whichever lands second reconciles trivially in the stack rebase. Verified: `bun run test` 11/11 stages green (unit and launcher sim both failed before this commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review — content is right, but the branch broke the unit gate; fixed and pushedVerdict: the demo itself is clean — after the pushed fix the full gate is green, so this merges once the stack under it does (it stacks on #257, which has open design findings of its own). What I ran
Pushed to this branch (822dc4c)
Notes
🤖 Generated with Claude Code |
|
Status update: #255 and #256 are merged. Your This PR is otherwise ready (gate was 11/11 green with the review fix) and now waits only on #257 — once that merges, rebase onto main and the remaining diff should be just 🤖 Generated with Claude Code |
…ncher display union Review fixes for pocket-stack#258: - apps/iphone16-demo/pocket.json landed without its row in the admission-matrix test, so the unit gate failed (expected[demo] undefined for every committed manifest is the test's contract). iphone16-demo resolves exactly like nsengine: vita-only through the shared touch + integer-fit contract, private ios-dev otherwise. - The committed launcher display registry (a cross-target union; each host intersects at runtime) regenerated via `bun tools/launcher.ts scan`, now carrying both vita-only demos, and the Vita-equality pin in tests/launcher-sim.test.ts evolves into subset + exact delta (["iphone16-demo-main", "nsengine-main"]). This overlaps the review commit on feat/ios-cli (f5a5975), which makes the same registry/test change for nsengine alone — whichever lands second reconciles trivially in the stack rebase. Verified: `bun run test` 11/11 stages green (unit and launcher sim both failed before this commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
d00b12c to
423ac77
Compare
|
Rebased onto the current #257 head and pushed, so this branch is a coherent stack again instead of conflicting against main.
Verification: The branch is now 🤖 Generated with Claude Code One note on the gate, since it cost me a couple of reruns: the unit stage failed 383/1 twice here, including with no concurrent run, but the same 38 files pass 384/0 standalone and a full-gate rerun goes 11/11 green in 39 s. That is the known macOS Gatekeeper first-launch stall on freshly linked test binaries ( |
…ncher display union Review fixes for pocket-stack#258: - apps/iphone16-demo/pocket.json landed without its row in the admission-matrix test, so the unit gate failed (expected[demo] undefined for every committed manifest is the test's contract). iphone16-demo resolves exactly like nsengine: vita-only through the shared touch + integer-fit contract, private ios-dev otherwise. - The committed launcher display registry (a cross-target union; each host intersects at runtime) regenerated via `bun tools/launcher.ts scan`, now carrying both vita-only demos, and the Vita-equality pin in tests/launcher-sim.test.ts evolves into subset + exact delta (["iphone16-demo-main", "nsengine-main"]). This overlaps the review commit on feat/ios-cli (f5a5975), which makes the same registry/test change for nsengine alone — whichever lands second reconciles trivially in the stack rebase. Verified: `bun run test` 11/11 stages green (unit and launcher sim both failed before this commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
423ac77 to
1c140ff
Compare
|
Rebased onto the new #257 head (the three review fixes just pushed there), replaying this PR's two commits — no conflicts, the demo files are disjoint from the tick-rate changes. Verified on the stack: 🤖 Generated with Claude Code |
The stock hero bakes PSP-demo defaults (Press Circle, 60 in the FPS tile, "running on a 2005 handheld"). Wrap it like apps/iphone2g-demo does so the ios-dev embedding shows its own device: Tap Me, an FPS tile tied to the baked tick rate, and an iPhone 16 Pro device line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ncher display union Review fixes for pocket-stack#258: - apps/iphone16-demo/pocket.json landed without its row in the admission-matrix test, so the unit gate failed (expected[demo] undefined for every committed manifest is the test's contract). iphone16-demo resolves exactly like nsengine: vita-only through the shared touch + integer-fit contract, private ios-dev otherwise. - The committed launcher display registry (a cross-target union; each host intersects at runtime) regenerated via `bun tools/launcher.ts scan`, now carrying both vita-only demos, and the Vita-equality pin in tests/launcher-sim.test.ts evolves into subset + exact delta (["iphone16-demo-main", "nsengine-main"]). This overlaps the review commit on feat/ios-cli (f5a5975), which makes the same registry/test change for nsengine alone — whichever lands second reconciles trivially in the stack rebase. Verified: `bun run test` 11/11 stages green (unit and launcher sim both failed before this commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1c140ff to
d05a254
Compare
|
Merged as |
Stacked on #257 (feat/tick-rate); only the last commit is new.
Following the
apps/iphone2g-demopattern, this addsapps/iphone16-demo.Validated:
bun tools/ios.ts build iphone16-demo --density=4 --hz=120resolves the ios-dev plan and builds;bunx tsc --noEmitandbun test tests/ios-profile.test.tspass.🤖 Generated with Claude Code