Skip to content

Fix: remove leftover profile rights and config on uninstall - #38

Merged
stonebuzz merged 1 commit into
mainfrom
fix_ci
Aug 27, 2026
Merged

Fix: remove leftover profile rights and config on uninstall#38
stonebuzz merged 1 commit into
mainfrom
fix_ci

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Aug 25, 2026

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • fixes #N/A
  • Uninstalling the plugin used to leave 45 rows in glpi_profilerights because the uninstall routine never removed the rights it had registered, and 2 rows in glpi_configs because a migration call passed a list instead of a key/value pair, which made GLPI store the config under numeric keys that the uninstall cleanup did not know about.
  • The uninstall routine now removes the profile rights, and the migration call is fixed to use the correct key/value syntax so the config values are stored and cleaned up under their real names.

Screenshots (if appropriate):

@Rom1-B
Rom1-B requested a review from stonebuzz August 25, 2026 06:54
@stonebuzz
stonebuzz merged commit 762f521 into main Aug 27, 2026
3 checks passed
@stonebuzz
stonebuzz deleted the fix_ci branch August 27, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants