Repository navigation
Conversation
…tion plan Phase-1 head-to-head scorecard (empirical: gates run on all four branches), Phase-2 reconciliation plan (per-contrast decisions + rationale, stacked on f40933d as reconcile/*), and a 'what both missed' list. Plan only — no reconciliation code until approved. Co-authored-by: Kiro Agent <244629292+kiro-agent@users.noreply.github.com>
This was referenced Jul 6, 2026
Owner
Author
|
Closing: the plan this PR proposes has been executed and merged upstream (awslabs#436 and awslabs#485), so there is no action left to take on the PR. The file itself is worth keeping and has been archived to disk — it is the macOS/arm64 half of a cross-platform gate pair with #16, and the two runs independently identify the same real defect (test/telemetry/test_optional_extra.py using the legacy find_module/load_module finder API that Python 3.12 no longer calls) while disagreeing only on platform-specific flakes. Branch preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Plan-only deliverable for the head-to-head evaluation of the Kiro and Claude remediations of upstream PR awslabs#387, plus the reconciliation plan to produce
reconcile/pr387-agui-coreandreconcile/pr387-a2a-hardened.No reconciliation code is written yet — this PR exists so the plan is reviewable first.
Contents (
docs/reviews/pr387-reconciliation-plan.md)emit_uirate-limiting;STATE_DELTAdebounce (both verified absent).Headline empirical findings
kiro/pr387-agui-core: 3487 passed / 0 failed, all gates green.claude/pr387-agui-core: 3 failed — 2 self-authored telemetry tests broken on Python 3.12 (find_moduleremoved) + 1 pre-existing macOS fifo flake.claude/pr387-a2a-hardened: 3595 passed / 0 failed.kiro/pr387-a2a-hardened: 3599 passed, 1 unrelated env flake.cao_pwa/src/api.ts(native EventSource drops the?since=cursor on reconnect); Kiro'sapi.tsis byte-identical to base (ships the bug) — corroborated by Kiro's own commit660e3f4.reset_jwks_cachelatent break + real-JWT roundtrip; Kiro has the broader 28-case (monkeypatched) matrix + cleaner extracted mount guard.Constraints honored
No pushes to
feat/*,kiro/*, orclaude/*. Reconciled branches will bereconcile/*, opened as drafts based onfeat/agentic-protocols-generative-ui, PR-A before PR-B (per @fanhongy).Verified empirically on macOS arm64; live Playwright specs were environment-blocked (only
chrome-headless-shellcached, no full Chromium) — documented in §0, reconnect correctness verified via source + green PWA unit suites instead.