Repository navigation
fix(tracker): allow numeric and boolean custom properties - #6751
Closed
marcel-mpunkt wants to merge 7 commits into
Closed
marcel-mpunkt wants to merge 7 commits into
marcel-mpunkt wants to merge 7 commits into
Conversation
|
|
4 tasks done
Contributor
|
Thanks @marcel-mpunkt! I reopened this PR from the main repo at #6774, our CI scripts don't support tracker-related work from forks. I also took the opportunity to do some maintenance work. Please sign the CLA in that PR and your fixes will be merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Allow numeric and boolean custom properties in the tracker’s TypeScript declarations by exporting
CustomPropertyValue = string | number | booleanand definingCustomProperties = Record<string, CustomPropertyValue>. This coverstrackprops, configured custom properties, and request payloads through the existing shared type.Plausible’s documentation explicitly lists strings, numbers, and booleans as accepted scalar values: Custom properties — Accepted values.
Validation
Strict TypeScript smoke check passed for event props, fixed/function configuration props, and payload props; objects and arrays remain rejected. Prettier, ESLint, and
git diff --checkpassed for the changed declaration. Full Playwright suite not run for this declaration-only change.