Repository navigation
Conversation
|
Hi @todateman, thanks for the PR. I'm afraid your manifest won't work as you expect, mainly because there is no such variant |
|
Hi, @valeros I forked a repository that includes https://github.com/todateman/framework-arduinorenesas-uno-mcr_rev20 You may be able to approve my pull request after the pull request to |
Great, your PR will be merged, once a new stable version of ArduinoCore-renesas is released. |
…MSIS variant folder
- boards/rmc_ra4m1_20.json: extra_flags had "-DARDUINO_RMC-RA4M1",
a hyphenated string that is not a valid C macro identifier. Passed
straight through to gcc as -D, this makes every compile fail with
"error: macro names must be identifiers". Changed to
-DARDUINO_RMC_RA4M1_20 (matches the framework-arduinorenesas-uno
boards.txt fix).
- boards/rmc_ra4m1_20.json: debug.jlink_device was "ra4m1", not a
device J-Link recognizes; changed to "R7FA4M1AB" to match
uno_r4_minima.json/uno_r4_wifi.json.
- builder/frameworks/fsp.py, cmsis.py: framework-renesas-fsp and
framework-cmsis-renesas only ship pre-generated variant folders for
MINIMA, UNOWIFIR4 and PORTENTA_C33 -- there is no "rmc_ra4m1_20"
folder in either package, so LDSCRIPT_PATH/CPPPATH/LIBPATH pointed
at nonexistent paths and the build would fail before even reaching
framework-arduinorenesas-uno. RMC-RA4M1 uses the same R7FA4M1AB
silicon/memory map as MINIMA, so alias the lookup in these two
files only ("MINIMA" when board.id == "rmc_ra4m1_20"); framework-
arduinorenesas-uno's own variant resolution (arduino.py) is
untouched and still uses the real rmc_ra4m1_20 variant.
Syncs with platformio/platform-renesas-ra (v1.5.0 -> v1.9.0: Nano R4 board support, other platform.py/fsp.py updates), resolving the board.id-tuple conflicts in builder/frameworks/fsp.py and platform.py that both upstream's nano_r4 addition and this fork's rmc_ra4m1_20 addition touched -- merged to include both board ids rather than picking one side. boards/rmc_ra4m1_20.json and its extra_flags/ jlink_device fixes are untouched.
|
Rebased on top of Also fixed two build-breaking issues found while verifying:
On @valeros's earlier point about the MINIMA-variant workaround: I understand getting |
|
Hi @valeros, could you approve the pending workflow run for this PR? The Could you approve it from the Actions tab, or let me know if I should push a new commit to trigger a fresh run for you to approve? |
|
Sorry, @valeros. |
Add RMC-RA4M1(R7FA4M1AB3CFP)
https://www2.himdx.net/mcr/product/download.html#ra4m1
"rmc_ra4m1_20.json" was created based on "uno_r4_minima.json".
"svd_path" is the same as R4 MINIMA, so you may need to modify it if you want to debug. (I haven't checked this.)