Skip to content

Two comments name a variant and inventory paths that do not exist #53

Description

@Nemo-010

Two comments name something that is not what the code uses.

scripts/verify-artifacts.sh:303-305 writes the build variant into the manifest and explains it as:

# Which build variant this is. "default" reads APPDIR as well as
# CROSS_LIBC_DLOPEN_ROOT; "strictenv" reads only the latter.

The value written is "${CLD_VARIANT:-default}", and the variant scripts/build.sh sets is portable (VARIANT=portable), which is also the only other value scripts/package-release.sh:62 accepts. There is no strictenv variant. A consumer reading the manifest comment would look for a value that never appears.

tools/gen_forward_shim.py:11-14 documents its own invocation as:

python3 tools/gen_forward_shim.py \
    --floor  inv/appdir.json \
    --target inv/arch.json \
    --out    src/forward-shim.c \
    --manifest src/forward-shim-manifest.json

There is no inv/ directory; the inventories are inventories/appdir.json and inventories/glibc-2.44.json, and src/Makefile passes those. A reader who copies the docstring gets a missing-file error.

Fix both to the values and paths the tree actually uses.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions