Two comments name something that is not what the code uses.
scripts/verify-artifacts.sh:303-305 writes the build variant into the manifest and explains it as:
# Which build variant this is. "default" reads APPDIR as well as
# CROSS_LIBC_DLOPEN_ROOT; "strictenv" reads only the latter.
The value written is "${CLD_VARIANT:-default}", and the variant scripts/build.sh sets is portable (VARIANT=portable), which is also the only other value scripts/package-release.sh:62 accepts. There is no strictenv variant. A consumer reading the manifest comment would look for a value that never appears.
tools/gen_forward_shim.py:11-14 documents its own invocation as:
python3 tools/gen_forward_shim.py \
--floor inv/appdir.json \
--target inv/arch.json \
--out src/forward-shim.c \
--manifest src/forward-shim-manifest.json
There is no inv/ directory; the inventories are inventories/appdir.json and inventories/glibc-2.44.json, and src/Makefile passes those. A reader who copies the docstring gets a missing-file error.
Fix both to the values and paths the tree actually uses.
Two comments name something that is not what the code uses.
scripts/verify-artifacts.sh:303-305writes the build variant into the manifest and explains it as:The value written is
"${CLD_VARIANT:-default}", and the variantscripts/build.shsets isportable(VARIANT=portable), which is also the only other valuescripts/package-release.sh:62accepts. There is nostrictenvvariant. A consumer reading the manifest comment would look for a value that never appears.tools/gen_forward_shim.py:11-14documents its own invocation as:There is no
inv/directory; the inventories areinventories/appdir.jsonandinventories/glibc-2.44.json, andsrc/Makefilepasses those. A reader who copies the docstring gets a missing-file error.Fix both to the values and paths the tree actually uses.