lazy loading licensing - #1058
Open
rurkss wants to merge 2 commits into
Open
Conversation
rurkss
marked this pull request as draft
May 12, 2025 18:34
…files are private methods in lib/license_finder/packages/manual_package.rb
rurkss
force-pushed
the
lazy_loading_licensing
branch
from
May 13, 2025 17:24
d06510a to
1ffb554
Compare
rurkss
marked this pull request as ready for review
May 13, 2025 17:27
wadewinningham
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize license_finder behavior for package by skipping unnecessary activations when license info is already resolved via decisions or spec
Motivation
In Yarn v1, packages often include numerous transitive dependencies that get placed within the node_modules folder. license_finder attempts a deep scan of the file system, looking for license-related files (e.g., LICENSE, COPYING, README) in these nested folders.
This scanning process is especially expensive for deeply nested packages and can take up to 10 seconds per package in the worst case. By skipping the activation step when license information has already been resolved via decisions or spec metadata, we significantly reduce unnecessary file system traversal and improve overall performance.