Skip to content

MoQ: wait for the bot's broadcast before subscribing to it #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipi87 merged 2 commits into from
Aug 13, 2026
Merged

MoQ: wait for the bot's broadcast before subscribing to it #167

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff8594
fix: wait for the bot's broadcast before subscribing to the transcript
kixelated Aug 3, 2026
61c4d97
fix: moq transport
vipyne Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions transports/moq-transport/src/moqTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,12 +578,22 @@ export class MoqTransport extends Transport {
);
});

// Transcript — a lossless JSON append-stream over a single track. We
// re-subscribe on each (re)connect; @moq/json's stream Consumer yields
// every appended record in order, losslessly.
// Transcript — a lossless JSON append-stream over a single track,
// re-subscribed on every (re-)announce. @moq/json's stream Consumer
// yields every appended record in order, losslessly.
//
// Gated on the announcement rather than the connection, because
// subscribing to a path nobody publishes yet gets the stream reset:
// a bot started in response to our own announcement necessarily
// appears after us. `Watch.Broadcast` gates itself this way for the
// catalog and audio; this track goes straight through `@moq/net`, so
// it needs the gate spelled out. Reading it off `Reload` rather than
// the established session means the gate spans reconnects.
this._signals.run((eff) => {
const conn = eff.get(this._reload!.established);
if (!conn) return;
if (!eff.get(this._reload!.announced).has(botPath)) return;

const botBroadcast = conn.consume(botPath);
const track = botBroadcast.subscribe(merged.transcriptTrack, 0);
const consumer = new Json.Stream.Consumer<RTVIMessage>(track, {
Expand Down
Loading