Modernize SnapPass: client-side encryption - #457
Open
neuhaus wants to merge 21 commits into
Open
Conversation
…cies, modernize python packaging, accessibility improvements. Fixes pinterest#436 Fixes pinterest#456 Fixes pinterest#415
…NTRIBUTING.rst, and remove obsolete MANIFEST.in
- Removed requirements.txt and dev-requirements.txt - Bumped Flask, Flask-Babel, and redis-py to modern versions - Bumped fakeredis to natively support RESP3/HELLO protocol - Updated Makefile, Dockerfile, and tox pipelines to use pyproject.toml - Fixed pip-audit vulnerabilities by bumping pytest and wheel
- Configured .bumpversion.cfg to manage pyproject.toml and __init__.py versions - Documented release process in CONTRIBUTING.rst - Enforced Python 3.10+ requirement in pyproject.toml - Bumped coverage, ruff, pip-audit, freezegun, tox, and mypy to latest versions - Cleaned up unused imports in tests.py - Updated CHANGELOG.rst for the 1.7.0 release
Contributor
Author
|
You might want to bump the version number to 2.0 |
- Fix SECRET_KEY evaluation in docker-compose.yml and main.py to prevent empty keys from bypassing checks. - Update redis.conf to require a minimum of 1mb for proto-max-bulk-len. - Restrict Redis ACL to only allow access to keys matching the exact 22-character urlsafe base64 length and 'snappass' prefix. - Add MAX_CONTENT_LENGTH of 512KB to Flask to prevent memory exhaustion. - Enforce 256KB payload limit in API routes and set_password UI. - Add localized error handling for payload size limits and update translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty comprehensive patch with breaking API changes:
Fixes #436
Fixes #456
Fixes #415
Fixes #458
Co-Authored-By: Google Gemini