Skip to content

fix: escape multi-character separators before building the cleanup regex #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −2
Open

fix: escape multi-character separators before building the cleanup regex #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/speakingurl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,9 +1605,11 @@
// eliminate duplicate separators
// add separator
// trim separators from start and end
var escapedSeparator = escapeChars(separator);

result = result.replace(/\s+/g, separator)
.replace(new RegExp('\\' + separator + '+', 'g'), separator)
.replace(new RegExp('(^\\' + separator + '+|\\' + separator + '+$)', 'g'), '');
.replace(new RegExp('(?:' + escapedSeparator + ')+', 'g'), separator)
.replace(new RegExp('^(?:' + escapedSeparator + ')+|(?:' + escapedSeparator + ')+$', 'g'), '');

if (truncate && result.length > truncate) {
lucky = result.charAt(truncate) === separator;
Expand Down
21 changes: 21 additions & 0 deletions test/test-separator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,27 @@ describe('getSlug separator', function () {

});

it('should separate with a multi-character separator', function (done) {

getSlug('Foo Bar Baz', {
separator: '..'
})
.should.eql('foo..bar..baz');

getSlug('Foo Bar Baz', {
separator: '++'
})
.should.eql('foo++bar++baz');

getSlug('Foo Bar Baz', {
separator: '()'
})
.should.eql('foo()bar()baz');

done();

});

it('should separate with non-whitespace, with trailing spaces', function (done) {

getSlug(' Foo Bar Baz ', {
Expand Down