Skip to content

Add strict types #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 2 commits into from
Oct 21, 2025
Merged

Add strict types #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140b3ca
Modify autoloader signature per spl_autoload_register docs
afilina Oct 16, 2025
afbb579
Add a return type to render::make_reader
afilina Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions phpdotnet/phd/Autoloader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Autoloader
*/
private static array $package_dirs = [];

public static function autoload($name)
public static function autoload(string $name): void
{
// Only try autoloading classes we know about (i.e. from our own namespace)
if (strncmp('phpdotnet\phd\\', $name, 14) === 0) {
Expand All @@ -24,12 +24,10 @@ public static function autoload($name)
fclose($fp);
require $file;

return false;
return;
}
trigger_error(vsprintf('Cannot find file for %s: %s', [$name, $file ?? $filename]), E_USER_ERROR);
}

return false;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
exit(0);
}

function make_reader(Config $config, OutputHandler $outputHandler) {
function make_reader(Config $config, OutputHandler $outputHandler): Reader {
//Partial Rendering
$idlist = $config->renderIds + $config->skipIds;
if (!empty($idlist)) {
Expand Down