Skip to content

fix: 馃悰 Add special case were registry is defined for library image #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielpof wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 馃悰 Add special case were registry is defined for library image #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
# NOTE: The version for both `imageswap-init` and `imageswap` should be identical for now.
# Some effort will need to be put in to be able to distringuish changes to one vs. the other
# in CI/Release steps.
IMAGESWAP_VERSION := v1.5.3
IMAGESWAP_INIT_VERSION := v1.5.3
IMAGESWAP_VERSION := v1.5.4
IMAGESWAP_INIT_VERSION := v1.5.4

REPO_ROOT := $(CURDIR)
APP_NAME ?= "imageswap.py"
Expand Down
6 changes: 6 additions & 0 deletions app/imageswap/imageswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,12 @@ def swap_image(container_spec):
no_registry = False
library_image = False

# special case when the image is a library image but also has docker.io
# example: 'docker.io/alpine:latest'
if image_split[0] == "docker.io" and "/" not in image_split[2]:
image = image.replace("docker.io/", "")
image_split = image.partition("/")

# Check if first section is a Registry URL
if "." in image_split[0] and image_split[1] != "" and image_split[2] != "":
image_registry = image_split[0]
Expand Down