Skip to content

Preserve parentheses around subscripted array constructors #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msepga wants to merge 1 commit into
base: 17-latest
Choose a base branch
from
Open

Preserve parentheses around subscripted array constructors #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/postgres_deparse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4639,6 +4639,7 @@ static void deparseAIndirection(DeparseState *state, A_Indirection *a_indirectio
IsA(a_indirection->arg, A_Expr) ||
IsA(a_indirection->arg, TypeCast) ||
IsA(a_indirection->arg, RowExpr) ||
IsA(a_indirection->arg, A_ArrayExpr) ||
(IsA(a_indirection->arg, ColumnRef) && !IsA(linitial(a_indirection->indirection), A_Indices)) ||
IsA(a_indirection->arg, JsonFuncExpr);

Expand Down
1 change: 1 addition & 0 deletions test/deparse_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const char* tests[] = {
"SELECT * FROM x WHERE id NOT IN (1, 2, 3)",
"SELECT * FROM x JOIN (SELECT n FROM z) b ON a.id = b.id",
"SELECT * FROM x WHERE y = z[5]",
"SELECT (ARRAY['a', 'b'])[1]",
"SELECT (foo(1)).y",
"SELECT proname, (SELECT regexp_split_to_array(proargtypes::text, ' '))[idx] AS argtype, proargnames[idx] AS argname FROM pg_proc",
"SELECT COALESCE((SELECT customer.sp_person(n.id) AS sp_person).city_id, NULL::int) AS city_id FROM customer.tb_customer n",
Expand Down
Loading