Add schema version tracking - #844
Open
seanlinsley wants to merge 1 commit into
Open
Conversation
keiko713
reviewed
Jul 28, 2026
| s.SnapshotVersionMajor = 1 | ||
| s.SnapshotVersionMinor = 0 | ||
| s.SnapshotVersion = 1 | ||
| s.SchemaVersion = 1 |
Contributor
There was a problem hiding this comment.
This PR still doesn't include the part of "allowing us to signal when the schema structure has significantly changed", right? (as simply putting 1 here)
Member
Author
There was a problem hiding this comment.
The internal PR paired with this starts using schema version as part of schema table change detection logic. Was there something else you had in mind?
Contributor
There was a problem hiding this comment.
Sorry, I completely misunderstood that part, never mind 🤦
lfittl
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
schema_versionto snapshots, allowing us to signal when the schema structure has significantly changed such that the pganalyze server needs to force a re-sync of the data (like #196 needed) or otherwise handle it specially (other than checking for optional fields, like normally done).Since we haven't been using
snapshot_version_majorandsnapshot_version_minor, and we don't foresee a need for minor version tracking, this PR renames them tosnapshot_versionandschema_versionto avoid needing to add a new field.