Add log lines from (devel) Postgres make check output - #842
Conversation
keiko713
left a comment
keiko713
left a comment
There was a problem hiding this comment.
Nice, it was easy to follow per commit. Just to double check - we'll need to create a follow up PR in docs to explain about new/updated categories?
|
@keiko713 yeah, and in the app to actually process them. Thanks for the review! |
| "ROW triggers with transition tables", "TO must specify", "FROM must specify", | ||
| }, | ||
| regexp: regexp.MustCompile(`^(?:` + | ||
| `partitions?\b.+` + |
There was a problem hiding this comment.
These also have a bunch of trailing .* that we can maybe avoid?
| `|could not find jsonpath variable "[^"]*"` + | ||
| `|syntax error at end of jsonpath input(?: at character \d+)?` + | ||
| `|no SQL/JSON item found for specified path(?: of column "[^"]*")?` + | ||
| `|JSON path expression .+` + |
msakrejda
left a comment
msakrejda
left a comment
There was a problem hiding this comment.
I've updated most of the introduced expressions to avoid a trailing .* or .+, and rewrote the match struct comment to note our philosophy about this (another set of eyes would be welcome there to make sure I captured that correctly).
Three log event types introduced in this PR are hard to tighten: permissionDenied, partitionError, and sqlJsonError. They cover a lot of ground. We could drop them or let them slide for now. These are only an issue if an unrelated log line containing PII is somehow stitched to the end of the line being captured without a joining newline, but that's not impossible if we have a bad enough stitching issue.
In addition, cannotDrop and connectionAuthorized are existing cases of the same over-broad capture. I can follow up on them separately.
3 participants
See individual commits:
Note that SQL_JSON_ERROR and PARTITION_ERROR are coarser-grained than a lot of the existing event types, but I think this is preferable to both keeping these as UNKNOWN and a proliferation of event types.