OpenAI API format support - #50
Open
RomaA2000 wants to merge 5 commits into
Open
Conversation
RomaA2000
marked this pull request as ready for review
November 27, 2023 14:54
artek0chumak
requested changes
Nov 29, 2023
| usage=usage, | ||
| ) | ||
|
|
||
| if request.stream: |
Collaborator
There was a problem hiding this comment.
May be it's better to send unprocesseble entity? How openai answering when you choose choices with streaming?
Author
There was a problem hiding this comment.
Because of OpenAI documentation, it is mandatory to send data like streaming if streaming is enabled (the stream terminated by a data: [DONE] message).
| - suffix (the language models we currently support do not support | ||
| suffix) | ||
| - logit_bias (to be supported by Petals engine) | ||
| - stream (to be supported by Petals engine) |
Collaborator
There was a problem hiding this comment.
Is stream is not supported? 馃え
Collaborator
There was a problem hiding this comment.
Docstring and code are not aligned with each other.
Collaborator
|
LGTM |
|
what's needed for this to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.