Refactor checks into a set and add Janet test suite check - #4
Closed
pepegar wants to merge 2 commits into
Closed
Conversation
Expand `nix flake check` from just parinfer formatting to also verify the project compiles (via the package derivation, which runs cargo test) and run the Janet test suite. This makes `nix flake check` a single command that validates everything. https://claude.ai/code/session_01Gcqi4mU3iHcN61yXdnhdne
Replace the manual Rust/Janet installation and individual test steps in the test jobs of ci.yml, release.yml, and nightly.yml with a single `nix flake check -L` invocation. This uses DeterminateSystems' Nix installer and magic-nix-cache for fast cached builds. The integration, twin, build, release, and smoke jobs are left unchanged as they require Docker, tui-wright, or cross-compilation tooling that isn't suitable for Nix. https://claude.ai/code/session_01Gcqi4mU3iHcN61yXdnhdne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructured the
checksattribute from a singleparinfercheck into a set of multiple checks, and added a new Janet test suite runner.Key Changes
checks.parinfertochecksset: Changed from a single check definition to a set-based structure that can contain multiple checksbuildcheck: Reuses the existinggentpackage derivation to verify the project compilesjanet-testscheck: New check that runs the Janet test suite by executingjanet/test/run.janetwith proper environment setup (temporary HOME directory)parinfercheck: Moved the existing parinfer formatting validation into the new checks set structure without functional changesImplementation Details
janet-testscheck copies the Janet source directory, sets proper permissions, and runs the test suite with an isolated HOME directorybuild,janet-tests,parinfer) are now organized under a singlechecksattribute set for better organization and discoverabilityhttps://claude.ai/code/session_01Gcqi4mU3iHcN61yXdnhdne