Bump rust-bitcoin minimums to the 0.32.10x line - #1879
Merged
benalleng merged 1 commit intoSep 14, 2026
Merged
Conversation
rust-bitcoin publishes two lines under the 0.32 major: the stable line (0.32.11) and a 0.32.1xx line (0.32.102). Cargo compares patch versions numerically, so 102 outranks 11, and an open ceiling resolves to the 1xx line regardless of which one the manifest names. The declared minimum drives Cargo-minimal.lock and the open ceiling drives Cargo-recent.lock, so the workspace already exercised both lines, one per leg of contrib/test.sh, without anyone deciding that on purpose. The minimum sat at 0.32.9, two lines behind what Cargo-recent.lock and every downstream consumer of the published payjoin crate already resolve. Raise the minimum to 0.32.102 so both legs converge on the same line instead of silently diverging. bitcoin-units moves to 0.1.101 for the same reason: bitcoin 0.32.102 requires bitcoin-units ^0.1.101, so the floor has to move together with it.
caarloshenriq
requested review from
DanGould,
benalleng and
spacebear21
as code owners
September 14, 2026 16:20
Collaborator
Coverage Report for CI Build 34867980010Coverage remained the same at 86.646%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818 (option b: adopt the 0.32.10x line as the floor, rather than pinning away from it).
Change
bitcoin: 0.32.9 → 0.32.102bitcoin-units: 0.1.3 → 0.1.101Cargo-minimal.lockandCargo-recent.lockregenerated viacontrib/update-lock-files.shRationale
rust-bitcoin publishes two lines under the 0.32 major, and cargo compares patch numbers numerically, so an open ceiling always resolves to the higher one regardless of which line is declared. The workspace's minimum sat at 0.32.9, which meant
Cargo-minimal.locktested a different line thanCargo-recent.lockand every downstream consumer of publishedpayjoin1.0.0, that crate declaresbitcoin ^0.32.9on crates.io with no upper bound, socargo add payjointoday already resolves 0.32.102 regardless of what this repo's CI pins.Pinning down to stable-only would only create a CI/reality mismatch, not protect anyone downstream. MSRV is not a blocker: 0.32.102 and 0.1.101 both declare rust-version 1.60.0, well under this workspace's 1.85 floor. Accepted risk: 0.32.100 was yanked before 101/102 shipped, so this line has had at least one bad release, worth keeping an eye on stability here going forward.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.