Specifi nginx via environment variable or skip test - #1237
Conversation
Pull Request Test Coverage Report for Build 20374581801Details
💛 - Coveralls |
nothingmuch
left a comment
There was a problem hiding this comment.
This looks good, I have only one suggestion to use an error enum { NginxNotAvailable, UnknownError(Box<dyn Error>) } instead of also making the NginxNotAvailable condition into a trait object, since these two branches are handled quite differently
This pr addresses payjoin#1227, it specifies an enironment variable for nginx which will be used during test run. it also removes nginxWithStream package from the dev shell. introduce error enum for nginx failures introduce error enum for nginx failures
nothingmuch
left a comment
There was a problem hiding this comment.
ACK.
since i opened the issue and suggested this solution i think another maintainer should at least concept ACK before merging
There was a problem hiding this comment.
partial tACK on c8017eb - I tested contrib/test.sh locally without nix and confirmed it skips the problematic tests.
We should be able to also remove the "add nginxWithStream to PATH" step in CI?
should that be done in this PR or a different one ? |
|
I'm actually not sure if it can be removed, looks like we still need nginxWithStream when setting the new environment variable. |
This pr addresses #1227, it specifies an enironment variable for nginx which will be used during test run. it also removes nginxWithStream package from the dev shell.
i used Claude AI to help me with nix
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.