Expired sessions should close the session

[arminsabouri]

I am realizing the behavior for handling an expired session is different when replaying and normal state machine progressions.

if SystemTime::now() > self.context.expiry {
            return Err(InternalSessionError::Expired(self.context.expiry).into());
        }

In most cases we return an error instead of closing the session and pushing an error event.

Originally posted by @arminsabouri in #1036 (comment)

[DanGould]

don't we want to throw an error and then have the error handler produce an event? Or is that separated where you think it should be unified?

[arminsabouri]

don't we want to throw an error and then have the error handler produce an event? Or is that separated where you think it should be unified?

yes this is essentially what I am thinking. Typestate should return a fatal state transition variant which closes the session and saves a session expired event.

[DanGould]

I'm a bit unclear, seems like a "yes" answer to an either-or question. You think separated or unified error production + event production?

[arminsabouri]

don't we want to throw an error

I dont think we should be returning an Err. I want to be clear about that. Instead doing what I suggested above.

Wdym by seperate or unified? Replaying will still check for expired session after a replaying all events. So in that sense its seperate

[arminsabouri]

Related comment: #1036 (comment)

[benalleng]

Is this something we would like to use the SessionEvent::Closed from #1078 with expiration as the follow up reason?