Fix bugs: CellMemAligned and Independent buffer overrun, var_view bad access - #1448
Open
lroberts36 wants to merge 7 commits into
Open
Fix bugs: CellMemAligned and Independent buffer overrun, var_view bad access#1448lroberts36 wants to merge 7 commits into
CellMemAligned and Independent buffer overrun, var_view bad access#1448lroberts36 wants to merge 7 commits into
Conversation
Collaborator
Author
|
@par-hermes format |
Contributor
|
Collaborator
Author
|
@par-hermes format |
Yurlungur
approved these changes
Sep 2, 2026
Yurlungur
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this
pdmullen
approved these changes
Sep 3, 2026
lroberts36
enabled auto-merge
September 3, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes two bugs (with help from @chadmeyer):
Metadata::CellMemAlignedandMetadata::Independentended up with index ranges that reached outside of the allocated memory for a field. This restricts the index range to prevent this. After looking at fixing this bug, I think that there is a general bug for variables withMetadata::Independentfor fill ghost (see issue Possible issue withMetadata::IndependentwhenMetadata::FillGhostis not set #1447) that I do not fix here.var_viewsto prevent UBPR Checklist