Skip to content

[Infrastructure/trivial] Bump Rocm CI container to 7.2.4 - #1414

Merged
pgrete merged 5 commits into
developfrom
pgrete/bump-rocm-container
Jul 28, 2026
Merged

[Infrastructure/trivial] Bump Rocm CI container to 7.2.4#1414
pgrete merged 5 commits into
developfrom
pgrete/bump-rocm-container

Conversation

@pgrete

@pgrete pgrete commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

  • Bump Rocm CI container to 7.2.4
  • Also remove deprecated Spock machine cfg
  • Also bump Kokkos from 5.1.0 to 5.1.1
  • Bump shipped OpenPMD from 0.17.0 to 0.17.1
  • The CMAKE_PREFIX_PATH within the CI env is still required
  • Fourier Transforms #1403 needs this as the new image contains rocfft
  • In a separate PR we can migrate our custom sort to Kokkos::sort as this is now also suppored (both by Kokkos and the updated container)

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • Any contribution that was created or modified with the assistance of generative AI is disclosed here and in code following the guidelines
  • (@lanl.gov employees) Update copyright on changed files

@pgrete
pgrete requested review from Yurlungur and acreyes July 16, 2026 21:42
@pgrete pgrete mentioned this pull request Jul 16, 2026
13 tasks
@Yurlungur
Yurlungur enabled auto-merge July 16, 2026 21:59

RUN apt-get clean && apt-get update -y && \
DEBIAN_FRONTEND="noninteractive" TZ=America/New_York apt-get install -y --no-install-recommends git python3-minimal libpython3-stdlib bc hwloc wget openssh-client python3-numpy python3-h5py python3-matplotlib lcov curl cmake ninja-build openmpi-bin libopenmpi-dev adios2-mpi-bin adios2-serial-bin libadios2-mpi-c++11-dev libadios2-mpi-core-dev libadios2-serial-core-dev libadios2-serial-c++11-dev && \
DEBIAN_FRONTEND="noninteractive" TZ=America/New_York apt-get install -y --no-install-recommends git python3-minimal libpython3-stdlib bc hwloc wget openssh-client python3-numpy python3-h5py python3-matplotlib lcov curl cmake ninja-build openmpi-bin libopenmpi-dev adios2-mpi-bin adios2-serial-bin libadios2-mpi-c++11-dev libadios2-mpi-core-dev libadios2-serial-core-dev libadios2-serial-c++11-dev libhdf5-dev libhdf5-openmpi-dev && \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ubuntu puts the openmpi variant in a nested directory, for me it ends up in /usr/include/hdf5/openmpi/, which might be the problem in CI.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was that the HDF5_ROOT var overwrote the default search paths. I now selective set it for non-hip builds (as the hip builds now pick up the ubuntu shipped version).

@pgrete
pgrete disabled auto-merge July 28, 2026 10:12
@pgrete
pgrete enabled auto-merge (squash) July 28, 2026 10:12
@pgrete
pgrete merged commit 6d6a97a into develop Jul 28, 2026
38 checks passed
@pgrete
pgrete deleted the pgrete/bump-rocm-container branch July 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants