Skip to content

Add user specifiable BCs to solvers (+ other small solver updates) - #1315

Merged
lroberts36 merged 6 commits into
developfrom
lroberts36/add-user-specifiable-BCs-to-solvers
Sep 16, 2025
Merged

Add user specifiable BCs to solvers (+ other small solver updates)#1315
lroberts36 merged 6 commits into
developfrom
lroberts36/add-user-specifiable-BCs-to-solvers

Conversation

@lroberts36

@lroberts36 lroberts36 commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

PR Summary

Add the option to define a SetBoundary function in a class defining a system of linear equations that will be used by the solvers instead of the default boundary conditions during boundary communication. Also moves some things common to all solvers to SolverBase and fixes a bug with the unique counters (previously, using multiple solvers within a single code was broken).

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pdmullen

pdmullen commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

Changelog and style.

Base automatically changed from lroberts36/add-user-boundary-override to develop September 11, 2025 23:53

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lroberts36
lroberts36 merged commit 10d8f84 into develop Sep 16, 2025
37 checks passed
@lroberts36
lroberts36 deleted the lroberts36/add-user-specifiable-BCs-to-solvers branch September 16, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants