Add user specifiable BCs to solvers (+ other small solver updates) - #1315
Merged
lroberts36 merged 6 commits intoSep 16, 2025
Merged
Conversation
12 tasks
12 tasks
pdmullen
approved these changes
Sep 8, 2025
Collaborator
|
Changelog and style. |
Base automatically changed from
lroberts36/add-user-boundary-override
to
develop
September 11, 2025 23:53
lroberts36
enabled auto-merge
September 16, 2025 17:04
lroberts36
deleted the
lroberts36/add-user-specifiable-BCs-to-solvers
branch
September 16, 2025 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add the option to define a
SetBoundaryfunction in a class defining a system of linear equations that will be used by the solvers instead of the default boundary conditions during boundary communication. Also moves some things common to all solvers toSolverBaseand fixes a bug with the unique counters (previously, using multiple solvers within a single code was broken).PR Checklist