WIP Add optional TaskStatus for StateDescriptor callbacks - #1295
Open
lroberts36 wants to merge 6 commits into
Open
WIP Add optional TaskStatus for StateDescriptor callbacks #1295lroberts36 wants to merge 6 commits into
TaskStatus for StateDescriptor callbacks #1295lroberts36 wants to merge 6 commits into
Conversation
Collaborator
|
looks like tests are failing... is this ready for review? Also thanks for just going ahead and doing this! |
Collaborator
Author
I think the failure was due to my linter not agreeing with the github linter, hopefully fixed now. Tests are passing on Darwin. It is ready for review, but I think @swjones is going to test and see if it works for him before it goes in. |
TaskStatus for StateDescriptor callbacks TaskStatus for StateDescriptor callbacks
Collaborator
|
@swjones could you please remove WIP again once you tested the functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR allows for functions like
FillDerivedto optionally return aTaskStatus.PR Checklist