Skip to content

feat: Add support to mongo allowDiskUse - #8337

Draft
stewones wants to merge 1 commit into
parse-community:alphafrom
stewones:feat/allowDiskUse
Draft

feat: Add support to mongo allowDiskUse#8337
stewones wants to merge 1 commit into
parse-community:alphafrom
stewones:feat/allowDiskUse

Conversation

@stewones

@stewones stewones commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

New Pull Request Checklist

Issue Description

Dependent: parse-community/Parse-SDK-JS#1623
Closes: #7765

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant

Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant Bot changed the title feat: add support to mongo allowDiskUse feat: Add support to mongo allowDiskUse Nov 27, 2022
@parse-github-assistant

parse-github-assistant Bot commented Nov 27, 2022

Copy link
Copy Markdown

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov

codecov Bot commented Nov 27, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.93%. Comparing base (6f52744) to head (96427c0).
⚠️ Report is 1398 commits behind head on alpha.

Files with missing lines Patch % Lines
src/Adapters/Storage/Mongo/MongoCollection.js 50.00% 1 Missing ⚠️
src/Routers/ClassesRouter.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8337      +/-   ##
==========================================
- Coverage   94.25%   93.93%   -0.33%     
==========================================
  Files         180      180              
  Lines       13960    13981      +21     
==========================================
- Hits        13158    13133      -25     
- Misses        802      848      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza mentioned this pull request Dec 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ability to use allowDiskUse on mongo

1 participant