Skip to content

Consume the editor from paranext-core's staged copy #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjcouch-sil merged 4 commits into from
Sep 14, 2026
Merged

Consume the editor from paranext-core's staged copy #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7cfbe5
build: consume the editor from paranext-core's staged copy
tjcouch-sil Aug 31, 2026
0ded421
build: stage core's dev packages in CI and refresh the lockfile
tjcouch-sil Sep 3, 2026
5b4d3f3
ci: call paranext-core's npm script rather than a path inside it
tjcouch-sil Sep 10, 2026
bd74dc6
ci: verify core's staged dev packages after installing core
tjcouch-sil Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ jobs:
paranext-core/package-lock.json
node-version-file: extension-repo/package.json

# Our editor `file:` dependency points into core's gitignored `dev-packages/staging/`, which
# only core's `preinstall` creates — and the core install below runs `--ignore-scripts`. npm
# links a missing `file:` target silently, so skipping this leaves a broken symlink.
- name: Stage paranext-core's dev packages
working-directory: paranext-core
run: npm run stage-dev-packages

- name: Install extension dependencies
working-directory: extension-repo
run: npm ci
Expand All @@ -44,6 +51,13 @@ jobs:
working-directory: paranext-core
run: npm ci --ignore-scripts

# The staged packages come from the branch dev-packages.json pins, which moves independently
# of core's commits, so the tree just installed can describe a different editor than core's
# lockfile does. Core's postinstall makes this check; `--ignore-scripts` above skips it.
- name: Verify core's staged dev packages match its lockfile
working-directory: paranext-core
run: npm run verify:dev-packages

- name: Run format checking
working-directory: extension-repo
run: npm run format:check
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ jobs:
paranext-core/package-lock.json
node-version: ${{ fromJson(steps.package_json.outputs.volta).node }}

# Our editor `file:` dependency points into core's gitignored `dev-packages/staging/`, which
# only core's `preinstall` creates — and the core install below runs `--ignore-scripts`. npm
# links a missing `file:` target silently, so skipping this leaves a broken symlink.
- name: Stage paranext-core's dev packages
working-directory: paranext-core
run: npm run stage-dev-packages

- name: Install packages
run: |
npm ci
Expand All @@ -82,6 +89,13 @@ jobs:
run: |
npm ci --ignore-scripts

# The staged packages come from the branch dev-packages.json pins, which moves independently
# of core's commits, so the tree just installed can describe a different editor than core's
# lockfile does. Core's postinstall makes this check; `--ignore-scripts` above skips it.
- name: Verify core's staged dev packages match its lockfile
working-directory: paranext-core
run: npm run verify:dev-packages

- name: Package for distribution
run: |
npm run package
Expand Down
Loading
Loading