Repository navigation
use tomlrt - #102
Merged
Merged
use tomlrt#102
Conversation
dimbleby
force-pushed
the
tomlrt
branch
2 times, most recently
from
July 21, 2026 22:12
6e2dbe7 to
3bd9eca
Compare
Contributor
Author
I had assumed yesterday that dropping orphaned comments was accidental, but perhaps it is not. In case it is deliberate: tomlrt can do that too. |
dimbleby
force-pushed
the
tomlrt
branch
2 times, most recently
from
July 24, 2026 15:07
68b37c9 to
4a71467
Compare
This was referenced Sep 12, 2026
Owner
|
Sorry for the late reply, I'm open to merge this soon! Can you update the CHANGELOG with any behavior changes you're aware of (if any)? |
Contributor
Author
I added a mention of the spaces around curly braces - as visible in the changes to fixtures in this PR, and mentioned above. Also did a |
Mention spaces around curly braces. Also `poetry update tomlrt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi -
I'm not sure if this is something you should want or not; but I've done it and I think it's interesting enough to show to you anyway.
I've been writing tomlrt, a library occupying roughly the same space as tomlkit. But - hopefully - faster, less buggy, with a cleaner API.
I've been using toml-sort as a testing ground for tomlrt: you are doing some reasonable but complicated stuff, getting tomlrt to support it has improved my library regardless of where this pull request goes.
Anyway the upshot of that is that toml-sort can now be implemented relatively cleanly via tomlrt APIs - no grubbing around in tomlkit internals and figuring out for yourself how to get hold of comments etc.
Per the diffs in the tests, the main visible changes are
I'm pretty sure that we also fix a small pile of open issues, probably #55, #59, #67, #69, #94, #101
By all means close this out: if it's of no interest, if toml-sort is basically done, if tomlkit is good enough, or really for any reason at all.