Restore "Long running tasks" logging when the dynamic UI is disabled - #23612
Open
tobni wants to merge 2 commits into
Open
Restore "Long running tasks" logging when the dynamic UI is disabled#23612tobni wants to merge 2 commits into
tobni wants to merge 2 commits into
Conversation
Both display modes consume that queue, so only enabling it for the dynamic UI stopped "Long running tasks:" from ever being logged. Draining it from the render tick instead of from its consumers keeps it bounded, which is what gating it was for.
tobni
added
needs-cherrypick
tdyas
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-introduces the "Long running tasks ..." log in CI environments, which I accidentally nuked when disabling the workunit message queues that were "never" polled.
This change instead drains said queue regularly (to avoid garbage), and logs if there are indeed stragglers during CI runs, which reportedly some environments depend on for keep-alive, see #23604.
Closes #23603